Simplify, tidy, and improve gitignore.py - #3
Open
sijk wants to merge 4 commits into
Open
Conversation
- Read list of available boilerplates from subdirectory - Easier to maintain - Don't inherit sublime.Window - This is a WindowCommand, not a Window - Removed duplicate code - first_select, second_select - 4 occurrences of essentially the same list - Removed hard-coded paths
Hmm... this repo needs a .gitignore! :-P
There was a problem hiding this comment.
On ST2 using Windows, this returns .\boilerplates, and causes line 10 to fail. It returns the full path in ST3 though (I'm currently making the plugin compatible with ST3)
Apparently using a relative path doesn't work on Windows.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I haven't changed any externally visible functionality, but I have greatly simplified the implementation.
It should now be easier to maintain this package since you won't have to update the list in gitignore.py (4 times!!) if you add/remove any boilerplate files.